id
int64
393k
2.82B
repo
stringclasses
68 values
title
stringlengths
1
936
body
stringlengths
0
256k
labels
stringlengths
2
508
priority
stringclasses
3 values
severity
stringclasses
3 values
51,281,862
go
cmd/compile: eliminate duplicate instrumentation in racewalk
<pre>Use simple analysis to eliminate duplicate instrumentation in cases like: x = ...; ... = x; Currently it leads to insertion of 2 raceread() calls.</pre>
Performance,RaceDetector
low
Minor
51,281,931
go
crypto/aes: add assembly for non-AES-NI machines
<pre>golang https server described in <a href="https://golang.org/issue/4073?c=8">https://golang.org/issue/4073?c=8</a> and tested with siege --benchmark --concurrent=100 &quot;<a href="https://localhost:8082&quot">https://localhost:8082&quot</a>; command gives Lifting the server siege... done. Transactions: ...
Performance,NeedsInvestigation
medium
Critical
51,281,959
go
syscall: package is underdocumented
by **szopa@google.com**: <pre>The standard library syscall package is underdocumented. I was trying to figure how to write my own utimensat (unimplemented) and I was having a very hard time. What is more, reading the source of the package doesn't really help, as its code is supposed to be going through mksyscall. Wha...
Documentation,NeedsInvestigation
low
Major
51,281,992
go
image/jpeg: correct for EXIF orientation?
<pre>JPEG files can embed EXIF metadata specifying one of 8 mirroring+rotation options. Only 2-3 of these are in common use, from people holding their phones sideways when taking pictures. It would be nice of the image/jpeg package could, perhaps optionally, correct for these. Camlistore will be doing it on its own,...
Thinking
medium
Critical
51,282,313
go
cmd/compile: possible error message improvement
<pre><a href="http://play.golang.org/p/87zosrj611">http://play.golang.org/p/87zosrj611</a> package main var x = 10 var y = 0.9 * x prog.go:4: constant 0.9 truncated to integer If you don't know that x is an int or that * requires both sides to have the same type, this is a bit of a leap. constant 0.9 truncated dur...
NeedsInvestigation
low
Critical
51,282,314
go
cmd/compile: which errors are confusing?
<pre>It would be fascinating to take each of the yyerror statements in cmd/gc and plug it into a google search to find mailing list threads about the errors. How are they misinterpreted? What could be clearer?</pre>
Suggested
low
Critical
51,282,442
go
x/pkgsite: switch to use html/template
<pre>Godoc should use the auto-escaping htm/template package instead of text/template, for security reasons. With text/template, it is hard to write UI code that doesn't introduce content injection vulnerabilities.</pre>
Security,pkgsite
low
Major
51,282,447
go
doc/tour: write more tours
by **jimmyok@google.com**: <pre>The go lang tour expects coding experience in a previous language, with comments like &quot;type does what you would expect&quot; I think for someone with little to no previous coding experience the tour would be next to impossible to finish. There are also a lot of examples with comp...
Documentation,NeedsInvestigation
low
Major
51,282,499
go
cmd/compile: error message for bad case in switch should suggest select
<pre>When writing a switch statement like this: package main func main() { ch := make(chan int) switch { case &lt;-ch: default: } } The compiler error is: prog.go:6: invalid case &lt;-ch in switch (mismatched types int and bool) This is a correct message, but for cases where the user is doi...
Thinking
low
Critical
51,282,548
go
text/template: Allow func to take region as final argument
<pre>I would like to extend Go templates to allow funcs to accept a region as an argument. This is useful any time you want to process or transform a section of text. For example, I would like to write a func that performs syntax highlighting (server-side, while all existing solutions are in javascript): {{/* A sam...
Thinking,FeatureRequest
low
Major
51,282,586
go
cmd/compile: omit zeroing of named return value when possible
<pre>In the program below, f1 and f2 should ideally generate the same code: if a return variable name is never mentioned in the function and there are no returns without arguments and no defer statements, the variable need not be cleared on entry: g% cat x.go package main type T [16]int func f1() (t T) { return ...
NeedsInvestigation
low
Major
51,282,600
go
cmd/go: go get broken for bzr with no-tree repos
by **bigjools**: <pre>What steps will reproduce the problem? 1. Set up no-tree repos, or, in bazaar.conf, set up an alias: &quot;branch = branch --no-tree&quot; 3. &quot;go get launchpad.net/juju-core/...&quot; What is the expected output? A valid working tree. What do you see instead? go get fails because my pac...
ExpertNeeded,Suggested
low
Critical
51,282,601
go
cmd/compile: init loop does not trace through inlined functions
<pre>$ cat x.go package p var x = f func f() { g() } func g() { _ = x } $ 6g x.go x.go:2: initialization loop: x.go:2 x refers to x.go:3 f refers to x.go:2 x Should be f refers to g refers to x (but g has been inlined into f and been dropped).</pre>
NeedsInvestigation
low
Major
51,282,673
go
go/printer: unhappy formatting of const declaration
<pre>in go/parser/interface.go: const ( PackageClauseOnly Mode = 1 &lt;&lt; iota // parsing stops after package clause ImportsOnly // parsing stops after import declarations ParseComments // parse comments and add them to AST ...
NeedsInvestigation
low
Critical
51,282,696
go
compress/bzip2: implement bz2 encoder
by **johnkgallagher**: <pre>All the other compress/* packages include both decompression and compression. compress/bzip2 only supports decompression.</pre>
FeatureRequest
medium
Critical
51,282,784
go
go/build: should package be aware of GOBIN?
<pre>When using build.Import(&quot;GOPATH/src/myCmd&quot;, &quot;&quot;, 0) a *Package is returned that has the field BinDir set to be GOPATH/bin. Package.BinDir is documented as &quot;command install directory&quot;. However: cmd/go states &quot;If the GOBIN environment variable is set, commands are installed to the ...
NeedsInvestigation
low
Major
51,282,964
go
cmd/asm: MOVL $x-8(SP) and LEAL x-8(SP) are different
<pre>MOVL $x-8(SP), AX assembles to raw LEAL -8(SP), AX. LEAL x-8(SP), AX assembles to raw LEAL (framesize-8)(SP), AX. It's a bit confusing that they have different interpretations of x-8(SP). Same for MOVQ on 6a. Can wait until after Go 1 because I think I'm the only one who ever uses that form instead of writing LE...
NeedsInvestigation
low
Major
51,283,032
go
cmd/go: reorganize documentation
<pre>The documentation for the go command appears in doc.go and then again in various files, plus appendices in package testing and package go/build. It's unwieldy to maintain and hard for users to think of where to look for each question. It would be nice to tidy this up at some point.</pre>
Documentation,NeedsFix,GoCommand
low
Major
51,283,046
go
image/gif: decoding untrusted (very large) images can cause huge memory allocations
by **jeff.allen**: <pre>What steps will reproduce the problem? 1. decode attached gif, get bad behavior due to giant malloc followed by giant memset(0). 2. finally get error about UnexpectedEOF because there is not as much pixel data as the bounds say there should be. The problem is that the gif has a frame in it tha...
Thinking
medium
Critical
51,283,059
go
x/pkgsite/internal/fetch/dochtml: BUG, TODO etc. should be re-thought
<pre>Godoc needs updated rules and a nice UI for interpreting and presenting BUG(foo), TODO(bar) etc. The current setup is odd: it treats things internal to functions specially, while things at top level are too loosely bound. For instance, // Foo bars blatz. // BUG(gopher): Foo should bing bang bam. func Foo() { } ...
Documentation,NeedsInvestigation,pkgsite,UX
low
Critical
51,283,134
go
cmd/link: use more standard calling convention on arm
<pre>Unlike the 386 and amd64, arm stores the return address in the word at the top of the stack rather than in the word below the incoming parameter area. This is a deviation from the native arm calling convention which also stores the return address below the incoming parameter area. Following the native convention...
NeedsInvestigation
medium
Critical
51,283,162
go
cmd/gofmt: reformats block comments
by **borman@google.com**: <pre>What steps will reproduce the problem? Use /* */ for block comments. Example: func f() { /* * don't do this right now fmt.Printf(`a multi-line string`) */ return } Gofmt alters the content of the comment (which includes the /* and */). The fi...
Thinking
medium
Critical
51,283,164
go
cmd/compile: more clever syntax error reporting
<pre>Using the go 1.0.3 compiler, the code at <a href="http://play.golang.org/p/mSSyjMd_MU">http://play.golang.org/p/mSSyjMd_MU</a> gives a syntax error on line 15 that there is an unexpected ), while the actual error is that there is a missing } on line 10. In this specific case, hypothetically the compiler could real...
NeedsInvestigation
low
Critical
51,283,189
go
cmd/compile: too many errors stops too early -- check other related errors
<pre>I'm in the middle of debugging a package which is full of a bunch of code I wrote quickly. At present, the package consists of three files <a href="http://play.golang.org/p/XgNpoFpwcp">http://play.golang.org/p/XgNpoFpwcp</a> filename fluidtensors.go <a href="http://play.golang.org/p/p9897ak11y">http://play.gola...
NeedsInvestigation
low
Critical
51,283,196
go
runtime: consider caching previous map hash value
<pre>Michael Jones notes that the following pattern is common in Go code: if v, ok := map[key]; ok { // or !ok .... map[key] = newValue } If hashing that key type is expensive (say: large string/struct) and the map isn't empty or very small, the above code does it twice. If we kept a per-P cache of t...
Performance
medium
Critical
51,283,217
go
encoding/json: use the Error method to marshal an error value?
<pre>What steps will reproduce the problem? <a href="http://play.golang.org/p/epXpwk0s4s">http://play.golang.org/p/epXpwk0s4s</a> What is the expected output? Something like this: <a href="http://play.golang.org/p/Dk0l6fTj01">http://play.golang.org/p/Dk0l6fTj01</a> What do you see instead? {&quot;bar&quot;:{},&quot;f...
Thinking,v2
medium
Critical
51,283,229
go
proposal: database/sql: support a way to perform bulk actions
<pre>The current implementation of database/sql doesn't provide a way to insert multiple rows at once, without getting to the wire upon every call to db.Exec There are APIs outside which either provide a general way for bulk actions cf. SQLBulkCopy of ADO.NET 2.0 [1] or has a specifier upto how many statements sho...
help wanted,Proposal,FeatureRequest
medium
Critical
51,283,301
go
cmd/link: support gdb debugging when hostlinking
<pre>When linking with the host linker, the .debug_gdb_scripts symbol isn't emitted, causing the gdb python script to not be loaded. It appears that this isn't the only problem since manually loading the script throws the following error: Loading Go Runtime support. Traceback (most recent call last): File &quot;../...
NeedsInvestigation
medium
Critical
51,283,359
go
cmd/cgo: -godefs doesn't handle embedded struct fields correctly
by **Mortdeus@gocos2d.org**: <pre>Before filing a bug, please check whether it has been fixed since the latest release. Search the issue tracker and check that you're running the latest version of Go: Run &quot;go version&quot; and compare against <a href="http://golang.org/doc/devel/release.html">http://golang.org/d...
NeedsInvestigation
medium
Critical
51,283,363
go
cmd/cgo: godefs shouldnt try to guess which struct field's identifier prefixes preceding `_` is okay to strip.
by **Mortdeus@gocos2d.org**: <pre>Godef may produce structs with multiple declarations of the same field identifiers if its allowed to automatically strip the prefix of a C struct's field identifier. For example, When this C struct struct drm_drawable_info { unsigned int num_rects; struct drm_clip_rect *...
NeedsInvestigation
low
Major
51,283,396
go
cmd/go: print shell commands safely
<pre>The printing of commands by the go tool is simple-minded, can be incorrect in the face of empty strings and other issues, ignores system-dependent issues ($foo vs %foo; quoting, etc.) and should be improved. The current setup just calls Printf or special formatting routines that sometimes (not always) expand varia...
NeedsInvestigation
low
Major
51,283,412
go
spec: Clarify semantics of interface to interface assignment
<pre>When assigning an interface to an interface, the dynamic value of the LHS becomes the dynamic value of the RHS, but this is not stated anywhere in the spec. This came up in a discussion I had with a developer who was confused because he could not use the reflect package to find the method set of an interface. He ...
Documentation,NeedsFix
low
Major
51,283,441
go
runtime: detect zombie goroutines
<pre>Runtime can detect goroutines blocked on unreachable chans/mutexes/etc and report such cases. This needs an interface in http/pprof to query zombie goroutines on running services. And probably testing package integration to test for absence of zombie goroutines.</pre>
NeedsDecision,FeatureRequest
low
Major
51,283,489
go
net: cgoLookupIPCNAME doesn't try again for temporary failures in getaddrinfo()
<pre>go version devel +55f0ec9b3c00 Mon Apr 22 22:09:11 2013 -0700 linux/amd64 Heavy usage of net.Dial via net/http.Get gives errors stringifying as &quot; Temporary failure in name resolution&quot; which corresponds to EAI_AGAIN returned from getaddrinfo(). I expect net.Dial to retry on this error code. I'm using 6...
NeedsInvestigation
low
Critical
51,283,509
go
go/printer: think about format for chained calls
by **tshaked@google.com**: <pre>var ss = s.NewConfig(). User(&quot;t&quot;). DataLayout( sssssss.NewDataLayout(). BaseDir(&quot;/c&quot;). StartDate(&quot;2013-01-01&quot;). Sh( s.PN{ P: 1, N: 10}). H(7). Hon(0.01))</pre>
Thinking
low
Major
51,283,525
go
runtime/race: instrument Sendmsg/Recvmsg and Flock
<pre>What steps will reproduce the problem? write a program that synchronizes due to calls to Sendmsg and Recvmsg build and test with -race What do you see instead? a race is detected Which compiler are you using (5g, 6g, 8g, gccgo)? 6g Which operating system are you using? linux Which version are you using? ...
RaceDetector
low
Critical
51,283,532
go
cmd/compile: avoid closure for captured dynamic constant
<pre>The compiler is not very smart about compiling away closures. The following function needlessly allocates a closure at runtime func main() { s := &quot;&quot; f := func () { println(s) } g(f) } This example should succumb to closure analysis. The closure should be eliminated at compile time and replaced ...
NeedsInvestigation
low
Major
51,283,541
go
proposal: spec: byte view: type that can represent a []byte or string
<pre>Go has no built-in type which can represent a read-only view of possibly-changing bytes. We have two current types which internally are a byte pointer and a length: (the first also has a capacity, irrelevant to this issue) []byte Allowance: &quot;you can mess with this memory&quot; Restriction: &quot;t...
LanguageChange,Proposal,LanguageChangeReview
medium
Major
51,283,633
go
path/filepath: Glob is case-sensitive on Windows
by **me@conradz.com**: <pre>What steps will reproduce the problem? Copy the program at <a href="http://play.golang.org/p/9G14FfcKES">http://play.golang.org/p/9G14FfcKES</a> into a .go file and run in a directory that has write permissions (it will create the test.txt file). What is the expected output? Files found ...
OS-Windows,NeedsDecision
medium
Critical
51,283,668
go
proposal: net/http/v2: thoughts for Go 2.0
<pre>Wishlist bug for what net/http would look like if we could make backwards-incompatible changes. Anything goes. I'll start: * Handler (<a href="http://golang.org/pkg/net/http/#Handler)">http://golang.org/pkg/net/http/#Handler)</a> currently takes a pointer to a 208 byte Request struct. * The Request struct (<...
v2
high
Critical
51,283,724
go
cmd/link: external linker generates larger binaries than 6l/8l
by **unclejacksons**: <pre>What steps will reproduce the problem? Using 6l from Go 1.1: go build -ldflags '-s -linkmode internal' -tags release github.com/valyala/ybc/apps/go/memcached wc -c memcached 1562016 memcached Using Go 1.1 the patch which passes '-s' to ld: go build -ldflags '-s' -tags release github.com...
NeedsInvestigation
low
Major
51,283,732
go
go/types: named types defined within a function print as if defined at package scope
<pre>package main type T int func f() { type T int } Both of these types are printed as &quot;main.T&quot;. This is ambiguous and confusing; the f-local type should have a different name. Not sure what 6g does.</pre>
NeedsInvestigation
low
Major
51,283,815
go
gdb: nothing works (windows amd64)
by **SmileKZS**: <pre>## What steps will reproduce the problem? 1. <a href="https://gist.github.com/smilekzs/5640921">https://gist.github.com/smilekzs/5640921</a> 2. go build test.go 3. gdb test.exe 4. run the following ``` (gdb) break main.main (gdb) r (gdb) n (gdb) n (gdb) n (gdb) p s (gdb) p S (gdb) p I (gdb) inf...
ExpertNeeded,OS-Windows
medium
Critical
51,283,854
go
x/net/ipv4: an address as a result of routing table lookup for source-routing, source address selection
<pre>In addition to Dst and IfIndex, ControlMessage should contain a member corresponding to ipi_spec_dst, from struct in_pktinfo. This is available when IP_PKTINFO is set. It's necessary when the IP address that a packet is received on is required, rather than the header destination address (which is what Dst represe...
NeedsInvestigation
medium
Critical
51,283,909
go
net/http/cgi: allow chunked body in request
by **cgmurray**: <pre>What steps will reproduce the problem? Why are requests with chunked transfer encoding not permitted in http/cgi? Is this according to the cgi specification? Git sends data (push) with chunked transfer encoding and I believe that it's supported in Apache. Side-note: By disabling the error-check ...
Suggested,help wanted,NeedsInvestigation
medium
Critical
51,283,955
go
cmd/link: add eabi tag to arm binary
by **namsgorf**: <pre>What steps will reproduce the problem? 1. Run &quot;readelf -A -- /path/to/go/binary&quot; What is the expected output? Something like the following, which is the result of running the same command on /bin/bash instead: Attribute Section: aeabi File Attributes Tag_CPU_name: &quot;7-A&quot; ...
NeedsInvestigation
low
Critical
51,284,037
go
regexp: no way to replace submatches with a function
by **denys.seguret**: <pre>ReplaceAllStringFunc is useful when you need to process the match to compute the replacement, but sometimes you need to match a bigger string than the one you want to replace. A similar function able to replace submatch(es) seems necessary. Let's say you have strings like input := `bla...
NeedsInvestigation
high
Critical
51,284,065
go
reflect: field lookup ignores methods that cancel fields (ambiguity is ignored)
<pre>1) $ cat x.go package main import &quot;reflect&quot; type S1 struct { m int } type S2 struct{} func (S2) m() int { return 0 } type S struct { S1 S2 } func main() { var s S t := reflect.TypeOf(s) if f, ok := t.FieldByName(&quot;m&quot;); ok { println(&quot;field found:&quot;, ...
NeedsInvestigation
low
Critical
51,284,067
go
all: test fails on IPv4- or IPv6-only kernels
<pre><a href="http://www.freebsd.org/ipv6/ipv6only.html">http://www.freebsd.org/ipv6/ipv6only.html</a> Sure, it fails, of course.</pre>
Testing
low
Minor
51,284,068
go
x/net/ipv4: test fails on IPv6-only kernels
<pre><a href="http://www.freebsd.org/ipv6/ipv6only.html">http://www.freebsd.org/ipv6/ipv6only.html</a> Sure, it fails.</pre>
NeedsInvestigation
low
Major
51,284,073
go
cmd/compile: emits unnecessary deferreturn
<pre>parent: 17086:2879112bff3d tip, linux/amd64 The program is: package main import &quot;sync&quot; func main() { println(foo(0)) } func foo(x int) int { // fast path if x != 42 { return x } // slow path mu.Lock() defer mu.Unlock() seq++ return seq } var ( mu syn...
Performance
low
Major
51,284,089
go
sync/atomic: support int/uint types
<pre>Add operations on int/uint types to sync/atomic package. int is used as indices/len/cap by slices/maps/chans, widely used in std lib interfaces and seems to be the &quot;default&quot; integer type otherwise. Current atomic interface forces to use casts to work with int type. Casts are ugly. There is another unple...
Thinking
medium
Major
51,284,095
go
x/pkgsite: option to show "exported" declarations of main packages
<pre>What steps will reproduce the problem? 1. Run godoc -http=:8080 2. Go to <a href="http://localhost:8080/pkg/">http://localhost:8080/pkg/</a> 3. Click on a package that is main What is the expected output? Documentation for exported components. What do you see instead? A blank page. Which operating system are ...
NeedsInvestigation
medium
Major
51,284,235
go
encoding/gob: encoder should ignore embedded structs with no exported fields
by **alan.strohm**: <pre>What steps will reproduce the problem? If possible, include a link to a program on play.golang.org. 1. <a href="http://play.golang.org/p/ayZMy_HFKE">http://play.golang.org/p/ayZMy_HFKE</a> What is the expected output? &quot;worked&quot; I don't see why hidden1 (an unexported field in an emb...
NeedsInvestigation
medium
Critical
51,284,302
go
x/pkgsite: show interface methods more prominently
by **szopa@google.com**: <pre>Right now, the whole interface has one link, and its code is included in its entirety. This is not very clear, as many interfaces are the main public entry point for many libraries. What I would like to see: 1. The index should contain links to interface methods. 2. Interface methods do...
NeedsDecision,pkgsite
medium
Critical
51,284,360
go
encoding/json: allow per-Encoder/per-Decoder registration of marshal/unmarshal functions
<pre>For example, if a user wants to marshal net.IP with custom code, we should provide a way to do that, probably a method on *Encoder. Similarly for *Decoder. Same for encoding/xml.</pre>
Proposal,Proposal-Accepted,early-in-cycle
high
Critical
51,284,379
go
cmd/link: move symtab out of mapped memory
<pre>Nothing in package runtime looks at the Go 'symtab' symbol anymore. Move it into unmapped memory, so that it is still in the file for debuggers but not mapped while the program runs. Low priority, since the size of the file will not be changing, and since the data is never paged in, the total memory cost is under...
NeedsInvestigation
low
Critical
51,284,385
go
cmd/compile: missed escape analysis opportunity
<pre>Escape analysis says that s escapes in this function even though it doesn't: func f(s *string) { *s = *s } If f is called as f(&amp;s), the compiler will (with inlining disabled) allocate s on the heap even though it could be allocated on the stack. For types that don't contain pointers, this doesn't happen....
NeedsInvestigation
medium
Major
51,284,439
go
cmd/cgo: atexit handlers not run
by **davidgreymackay**: <pre>What steps will reproduce the problem? Save the attached files into a directory and run make, then run ./stmain What is the expected output? &quot;This is a test.&quot; should display on the console. What do you see instead? Nothing. Which compiler are you using (5g, 6g, 8g, gccgo)? 6c,...
NeedsInvestigation
low
Major
51,284,522
go
text/tabwriter: elide trailing padding when last cell is empty
<pre>I would like to suggest a new switch for tabwriter that makes it discard trailing padding bytes when all subsequent cells on that line are empty. See example below. The third column is only filled in the first line. It's not possible to align that cell right of the second column without having extra padding on th...
NeedsInvestigation
low
Major
51,284,631
go
cmd/vet: diagnose set and not used
<pre>If you have: x := 1 _ = x x = 2 the spec allows this program and therefore the compilers accept it without comment. However, it would be nice if vet could tell you about 'set and not used' on the final line. Maybe this falls out of some code Alan already has lying around. Maybe not.</pre>
Analysis
low
Major
51,284,667
go
encoding/xml: more tests
<pre>encoding/xml is under-tested. Now that we have go tool cover, it might be nice to write some more tests, especially of things like name spaces, custom marshalers, custom unmarshalers, and the interaction between all those.</pre>
Suggested,Testing
medium
Major
51,284,684
go
runtime: threadcreate profile is broken
<pre>With the new scheduler threadcreate profile is broken. Most of the threads are created by sysmon thread, which stack is not very informative. We need to either remove the profile, or capture stack of the blocking cgo/syscall that caused new thread creation.</pre>
compiler/runtime
medium
Critical
51,284,716
go
x/pkgsite: show embedded methods
<pre>Fix the cmd/godoc side of issue <a href="https://code.google.com/p/go/source/detail?r=f5b37c93e4c5bb2962c">https://code.google.com/p/go/source/detail?r=f5b37c93e4c5bb2962c</a> added some methods to go1.txt that were always there, but neither cmd/godoc nor cmd/api (both with their own bad embedding rules) detecte...
NeedsDecision,Tools
medium
Critical
51,284,729
go
sync/atomic: 64-bit primitives are not supported on ARMv5
<pre>The following change introduced the armSwapUint64 <a href="https://code.google.com/p/go/source/detail?r=41d393af9bb8">https://code.google.com/p/go/source/detail?r=41d393af9bb8</a> This function, written in assembly, uses newer ARM instructions to perform a double width LL/SC. I believe this code is correct. Fo...
NeedsInvestigation
low
Major
51,284,806
go
sync: detect copying of Mutex
<pre>Discussion on golang-dev: <a href="https://groups.google.com/forum/#">https://groups.google.com/forum/#</a>!searchin/golang-dev/copying$20sync.mutex/golang-dev/3jCp3vd4BQ8/dqjjePtV8iwJ sync.Mutex can use the same technique as sync.Cond to detect copying. Package docs says &quot;Values containing the types define...
NeedsInvestigation
low
Major
51,284,831
go
cmd/compile: poor performance when accessing slices for numerical work (multiplying vectors)
by **dean.w.schulze**: <pre>Running the enclosed code the best runtime is 6.45 seconds. The same code in Java (JDK 1.7) runs in 4.8 seconds, a serious performance hit. For simple slice (go) / array (Java) access I would expect similar runtime performance. Go and Java code is below. Which operating system are you ...
Performance
low
Major
51,284,841
go
proposal: encoding/json: add "inline" struct tag
by **bjruth**: <pre>Discussion was conceived on golang-nuts: <a href="https://groups.google.com/forum/#!topic/golang-nuts/bAgNll-EMkI">https://groups.google.com/forum/#!topic/golang-nuts/bAgNll-EMkI</a> to add support for a flag that supports unmarshaling arbitary JSON into structs. A tag was announced for the mg...
Proposal,Proposal-Hold
high
Critical
51,284,973
go
runtime: win32 should support more than 64 processors
<pre>Windows 7 and Windows Server 2008 support up to 256 processors. It seems that, by default, a process is constrained to running in a single processor group which can be as large as 64 processors. To support more than 64 processors the scheduler needs to become aware of &quot;processor groups&quot; and allocate th...
OS-Windows
low
Minor
51,285,015
go
cmd/link: linker cannot discard unused but runtime-initialized global variables
<pre>The code.google.com/p/go.text/encoding/charmap package contains variable pairs like: var CodePage437 encoding.Encoding = &amp;codePage437 var codePage437 = charmap{ /* a data table */ } encoding.Encoding is an interface, so that the CodePage437 variable currently requires a convT2I call, in a package init functi...
NeedsInvestigation
low
Minor
51,285,044
go
gdb: 'next' command confused by cgo calls
by **kaoshi.juan82**: <pre>What steps will reproduce the problem? write these code: package main //#include &lt;stdio.h&gt; /* void Print(int i){ printf(&quot;result:%d\n&quot;,i); } */ import &quot;C&quot; func A() { a := 1 b := 2 c := 4 C.Print((C.int)(a+b+c)) } func main(...
NeedsInvestigation
low
Critical
51,285,097
go
crypto/tls: add PSK support
by **tiebingzhang**: <pre>RFC 4279 (<a href="http://tools.ietf.org/html/rfc4279#page-10)">http://tools.ietf.org/html/rfc4279#page-10)</a> added PSK to TLS. OpenSSL and GnuTLS already have support for it. The RFC defines three additional key exchange algorithms: PSK RSA-PSK DHE-PSK It would be nice to add at least PS...
NeedsDecision,FeatureRequest,Proposal-Crypto
high
Critical
51,285,104
go
proposal: spec: allow constants of arbitrary data structure type
by **RickySeltzer**: <pre>var each1 = []byte{'e', 'a', 'c', 'h'} const each2 = []byte{'e', 'a', 'c', 'h'} The 'var' is accepted, the 'const' is not. This is a defect in the language spec and design. 1. What is a short input program that triggers the error? <a href="http://play.golang.org/p/Jbo9waCn_h">http://pla...
LanguageChange,Proposal,LanguageChangeReview
high
Critical
51,285,242
go
spec: clarify intended behaviour of method values using promoted methods
<pre>What steps will reproduce the problem? Run this program: <a href="http://play.golang.org/p/pQb9VlrLkv">http://play.golang.org/p/pQb9VlrLkv</a> What is the expected output? Based on the spec, it's not clear if this should print &quot;1 1&quot; or &quot;1 2&quot;. What do you see instead? Running the program in...
Documentation,NeedsInvestigation
low
Critical
51,285,273
go
proposal: os/v2: Chown expects int, but os/user uses strings
<pre>[Noting down confusion from IRC] Chown takes ints, os/user Lookup returns strings. If someone wants to &quot;chown jdoe file&quot;, they're supposed to have platform-specific code to strconv from os/lookup strings to ints? I know backwards-compatibility means changes are hard, but this API does not seem ideal. ...
v2,Proposal
low
Critical
51,285,295
go
runtime/race: eliminate dependency on cmd/cgo
<pre>There is a circular dependency between runtime/race and cmd/cgo in -race build. Everything depends on runtime/race, but runtime/race is a cgo package. Currently it's resolved by a hack in go tool: // If we are not doing a cross-build, then record the binary we'll // generate for cgo as a dependency of the...
RaceDetector,FeatureRequest
medium
Major
51,285,340
go
misc/swig: long long not working with gcc 4.7 on Windows
<pre>What steps will reproduce the problem? 1. grab the file at <a href="https://gist.github.com/steeve/6872454">https://gist.github.com/steeve/6872454</a> 2. on windows/386: go run test-int64.go What is the expected output? 1 What do you see instead? 4603183328 Which compiler are you using (5g, 6g, 8g, gccgo)? 8g,...
OS-Windows
low
Major
51,285,358
go
go/printer: printed output cannot be parsed if comments are retained
<pre>This program: <a href="http://play.golang.org/p/f3VrIs2Z70">http://play.golang.org/p/f3VrIs2Z70</a> parses a syntactically well-formed Go program, inserts an additional statement, then prints it out again. The result cannot be parsed because a newline was inserted in an inappropriate place to accommodate a comm...
Thinking
low
Minor
51,285,400
go
reflect: clarify that behaviour of Value returned from Value.Method is different from method value
<pre>What steps will reproduce the problem? <a href="http://play.golang.org/p/xPA5hW4GQe">http://play.golang.org/p/xPA5hW4GQe</a> What is the expected output? Some users might expect the receiver of a function value returned by Value.Method to be evaluated the same way it is for a method value once they've removed i...
Documentation,NeedsInvestigation
low
Minor
51,285,410
go
cmd/compile: 8MB error message for one char error
<pre>$ cat x.go package p type A interface { a() interface{AB} } type B interface { a() interface{AB} } type AB interface { a() interface{A;B} b() interface{A;B} } var x AB var y interface{A;B} var _ = x == y $ go tool 6g x.go x.go:12: duplicate method a x.go:13: duplicate method a x.go:17: duplic...
NeedsInvestigation
low
Critical
51,285,411
go
cmd/compile: odd/inconsistent behavior with cyclic declarations
<pre>This applies to: $ go version go version go1.1.1 linux/amd64 The following program compiles w/o errors: package p import &quot;unsafe&quot; type A [unsafe.Sizeof(x)]T type T interface { m(A) } var x T Adding one extra declaration leads to a cycle error: package p i...
NeedsInvestigation
low
Critical
51,285,423
go
misc/gdb: freezes and consumes CPU when using "info locals"
by **newton688**: <pre>Before filing a bug, please check whether it has been fixed since the latest release. Search the issue tracker and check that you're running the latest version of Go: Run &quot;go version&quot; and compare against <a href="http://golang.org/doc/devel/release.html">http://golang.org/doc/devel/re...
NeedsInvestigation
low
Critical
51,285,424
go
gdb: not showing Go strings values as initialized
by **newton688**: <pre>Before filing a bug, please check whether it has been fixed since the latest release. Search the issue tracker and check that you're running the latest version of Go: Run &quot;go version&quot; and compare against <a href="http://golang.org/doc/devel/release.html">http://golang.org/doc/devel/re...
NeedsInvestigation
low
Critical
51,285,425
go
x/pkgsite: show exported fields promoted from unexported anonymous fields
<pre>Within my code, I have the following structure. type common struct { Option1 bool } func (c *common) Method1() { } type A struct { OptionA int common } type B struct { OptionB int common } I want godoc to show that type A and type B have field Option1 available, and Method1 in their method...
NeedsDecision
medium
Major
51,285,427
go
cmd/compile: spurious error for recursive anonymous interface type
<pre><a href="http://play.golang.org/p/SV4pqRxk2g">http://play.golang.org/p/SV4pqRxk2g</a> This program can't be linked because the compiler generates a very long symbol for an anonymous interface type with an infinite unrolling.</pre>
NeedsInvestigation
low
Critical
51,285,477
go
image/gif: encoder does not honor image bounds.
by **dan.pupius**: <pre>1. Open a image using gif.DecodeAll 2. Replace frame(s) with a `SubImage`, e.g. to make a square crop 3. Save image using gif.EncodeAll What is the expected output? Saved image should correctly show cropped region What do you see instead? Resultant image is incorrectly offset, see lucha.out.g...
help wanted
low
Major
51,285,480
go
cmd/compile: internal compiler error with self-referential method in interface
<pre>$ cat x.go package p import &quot;unsafe&quot; type T interface { m() [unsafe.Sizeof(T(nil).m())]int } $ go tool 6g x.go x.go:6: internal compiler error: getinarg: not a func E-36 &lt;&lt;S&gt;&gt; &lt;T&gt;</pre>
NeedsInvestigation
low
Critical
51,285,489
go
cmd/compile: use less memory for large []byte literal
<pre>[]byte literals take up a lot of memory inside the compiler, because each byte in the literal is a separate syntax Node and, worse, each byte is represented by a multiprecision integer constant. Probably a trick is required during parsing to turn []byte{...} into an actual byte array holding the constant values +...
help wanted,ToolSpeed,NeedsFix
low
Major
51,285,499
go
x/pkgsite: display type kind of each named type
<pre>Currently godoc does not list the base type of type, for example: <a href="http://golang.org/pkg/encoding/json/#Decoder">http://golang.org/pkg/encoding/json/#Decoder</a> type Decoder func NewDecoder(r io.Reader) *Decoder func (dec *Decoder) Buffered() io.Reader type Marshaler type MarshalerError func...
NeedsInvestigation
low
Critical
51,285,546
go
cmd/cgo: more mkall.sh behaviour changes at tip
<pre>What steps will reproduce the problem? Fedora 19 x86_64 gcc-4.8.1-1.fc19.x86_64 GOARCH=amd64 GOOS=linux ./mkall.sh What do you see instead? some constants like VDISCARD are showing up in zerrors_linux_amd64.go although they are defined in types_linux.go, which leads to a compile error the Rusage struct loses...
NeedsInvestigation
low
Critical
51,285,566
go
runtime/race: say where the memory block was allocated
<pre>C++ ThreadSanitizer describes where the memory involved in report was allocated: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/tsan/lit_tests/malloc_stack.cc?revision=187875&amp">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/tsan/lit_tests/malloc_stack.cc?revision=187875&amp</a>;vi...
RaceDetector
low
Major
51,285,594
go
testing: add test helpers for measuring goroutine leaks
<pre>It's common for tests to check for goroutine leaks, but the testing package or standard library doesn't make this easy. These tests end up verbose and often frail. We should provide something.</pre>
NeedsInvestigation,FeatureRequest
medium
Critical
51,285,606
go
cmd/compile: skip slicebytetostring when argument doesn't escape
<pre>In this function, func hi() string { b := make([]byte, 0, 100) // 1st alloc b = append(b, &quot;Hello, &quot;...) b = append(b, &quot;world.\n&quot;...) return string(b) // 2nd alloc, but could be removed. } The final line currently generates a call to runtime.slicebytetostring, c...
Performance,GarbageCollector
medium
Critical
51,285,626
go
crypto/tls: needs a convenience function for reading encrypted keys
by **jeff.allen**: <pre>crypto/tls.X509KeyPair can't deal with encrypted key files. This wouldn't be much of a big deal except that the quantity of code needed to work around it is really big and repeats lots of code from the std library. See this message: <a href="https://groups.google.com/d/msg/golang-nuts/ht_gQ2ET...
NeedsInvestigation
low
Critical
51,285,670
go
cmd/compile: support for explicit alignment annotations
by **rayneolivetti**: <pre>Data alignment other than 8 bytes (ex: 128-bits, 256-bits, 512-bits) is necessary for various instructions (belonging to SSE/AVX/AVX2 and the upcoming AVX-512). Instruction and label alignment contributes to speed for some instructions. It would hugely be helpful to be able to specify the a...
Thinking
low
Major
51,285,672
go
runtime: sockets closed by remote peer may remain undetected by poller
<pre>I have observed a network TCP server blocked on a Write although the client (Go program located on a remote machine) has closed the connection. So far I have been unable to produce a minimal reproducer. My hypothesis is that the poller is not handling EPOLLRDHUP correctly. map epoll_ctl(2) says that it means: &q...
NeedsInvestigation
low
Major
51,285,698
go
go/types: make go/types more tolerant in case of 'import "C"'
<pre>gotype $GOROOT/src/pkg/net leads to several error messages due to unresolvable 'import &quot;C&quot;'. go/types could be more tolerant with invalid operands and types to avoid follow-up errors. (For instance, conversions of the form T(x) could always succeed even if x is invalid. Other operations should not rep...
NeedsInvestigation
low
Critical
51,285,729
go
proposal: strings: AppendSplitN to reuse destination slice buffer
<pre>I recently found myself forking strings.SplitN to take a destination buffer, to avoid the slice allocation. I called it AppendSplitN, with append semantics. (like the Append funcs in <a href="http://golang.org/pkg/strconv/)">http://golang.org/pkg/strconv/)</a> Maybe worth putting in the strings package, althoug...
Performance,GarbageCollector
low
Minor
51,285,770
go
cmd/compile: improve compiler error message when accessing type instead of instance of type
<pre><a href="http://play.golang.org/p/54n3Rs7JHT">http://play.golang.org/p/54n3Rs7JHT</a> If you have a function that has f which is a Foo, and try to reference Foo.Bar instead of f.Bar, you get the following error message: prog.go:10: Foo.Bar undefined (type Foo has no method Bar) [process exited with non-zero sta...
NeedsInvestigation
low
Critical
51,285,773
go
os: "async" file IO
<pre>Read/Write file operations must not consume threads, and use the polling similar to net package. This was raised several times before. Here is a particular example with godoc: <a href="https://groups.google.com/d/msg/golang-nuts/TeNvQqf4tO4/dskZuFH5QVYJ">https://groups.google.com/d/msg/golang-nuts/TeNvQqf4tO4/ds...
Performance,NeedsInvestigation
medium
Critical